[FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

[Nicolas George]

Sorry, forgot to reply to that.

Limin Wang (12020-04-04):
> the md5 framecrc is generated by libavformat/tests/movenc.c, I have no
> clue how the movenc testing work and how to get the real input to check why
> the frame isn't bitexact as I haven't see any subtitle track. 

Well, check: re-run the test manually, change it to have an actual
output, examine the file. The possibilities are many.

But tests are there for a reason. If a patch changes the output of
tests, then we cannot accept it unless somebody did examine the changes
very carefully and confirmed they are for the best. Ideally, an
explanation of the changes goes in the commit message.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200416/75967e25/attachment.sig>