[FFmpeg-devel] [PATCH] [GSOC] libavfilter/vf_colorconstancy.c : Adding weighted greyedge

[Moritz Barsnick]

On Thu, Apr 16, 2020 at 18:39:58 +0530, YATENDRA SINGH wrote:
> > As Michael noted, please resend without broken like feeds. I can't read
> > most of the diff the way it is now.
> >
> Sorry but I could not understand what broken by newlines mean. Can you
> explain a little bit further?

Your mailer introduced line wraps, making it impossible to apply the
patch, and difficult to read.

See what it looks like here:
http://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/260651.html
(E.g. scroll to the bottom and check what stuff should be on one line,
but isn't.)

> > Documentation update missing (and eventually changelog).
> >
> Is this documentation supposed to be different from the autogenerated one
> for the functions that I have placed?

Not for the functions, rather for the use of the filter and its
options. See doc/filters.texi.

> Also git send-email is not working for some reason and I am always stuck on
> the same SMTP error, so I have attached the patch updated based on the
> suggestions.

Yes, this patch is not corrupted anymore.

Cheers,
Moritz