[FFmpeg-devel] [PATCH v1] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

Nicolas George george at nsup.org
Fri Apr 17 16:27:13 EEST 2020


James Almer (12020-04-17):
> The change is effectively just the keyframe flag being added to audio
> packets in all of the movenc tests.
> 
> To verify, simply apply
<snip>
> without your patch, and you'll get the same changes in the test.

I would be more comfortable with the information that it was checked
externally. For example by checking the output of ffprobe on the
produced files before and after the patch. Seems like an obvious step.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200417/ad161186/attachment.sig>


More information about the ffmpeg-devel mailing list