[FFmpeg-devel] [PATCH] avcodec/pngdec: set return value on av_stereo3d_create_side_data() failure

[Vittorio Giovara]

On Fri, Apr 17, 2020 at 8:37 AM Peter Ross <pross at xvid.org> wrote:

> ---
>  libavcodec/pngdec.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
> index 7e2c19bd57..12d4eb0610 100644
> --- a/libavcodec/pngdec.c
> +++ b/libavcodec/pngdec.c
> @@ -1286,8 +1286,10 @@ static int decode_frame_common(AVCodecContext
> *avctx, PNGDecContext *s,
>          case MKTAG('s', 'T', 'E', 'R'): {
>              int mode = bytestream2_get_byte(&s->gb);
>              AVStereo3D *stereo3d = av_stereo3d_create_side_data(p);
> -            if (!stereo3d)
> +            if (!stereo3d) {
> +                ret = AVERROR(ENOMEM);
>                  goto fail;
> +            }
>
>              if (mode == 0 || mode == 1) {
>                  stereo3d->type  = AV_STEREO3D_SIDEBYSIDE;
> --
> 2.20.1
>

lgtm
-- 
Vittorio