[FFmpeg-devel] [PATCH 6/9] lavfi/vf_pp: convert to the video_enc_params API

[Carl Eugen Hoyos]

Am Sa., 18. Apr. 2020 um 19:03 Uhr schrieb Marton Balint <cus at passwd.hu>:
>
> On Sat, 18 Apr 2020, Michael Niedermayer wrote:
>
> > On Sat, Apr 18, 2020 at 12:14:12PM +0200, Anton Khirnov wrote:
> > [...]
> >> diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
> >> index 3d0d4969b8..cb7ce7a158 100644
> >> --- a/tests/fate/filter-video.mak
> >> +++ b/tests/fate/filter-video.mak
> >> @@ -535,7 +535,7 @@ FATE_FILTER_PP = fate-filter-pp fate-filter-pp1 fate-filter-pp2 fate-filter-pp3
> >>  FATE_FILTER_VSYNTH-$(CONFIG_PP_FILTER) += $(FATE_FILTER_PP)
> >>  $(FATE_FILTER_PP): fate-vsynth1-mpeg4-qprd
> >>
> >> -fate-filter-pp:  CMD = framecrc -flags bitexact -idct simple -i $(TARGET_PATH)/tests/data/fate/vsynth1-mpeg4-qprd.avi -frames:v 5 -flags +bitexact -vf "pp=be/hb/vb/tn/l5/al"
> >> +fate-filter-pp:  CMD = framecrc -flags bitexact -export_side_data venc_params -idct simple -i $(TARGET_PATH)/tests/data/fate/vsynth1-mpeg4-qprd.avi -frames:v 5 -flags +bitexact -vf "pp=be/hb/vb/tn/l5/al"
> >
> > ffmpeg / ffplay should automatically enable the exportation of the parameters
> > when theres a filter downstream that needs such parameters
> >
> > Otherwise the use of these filters (and other filters that need any kind of
> > information thats unavailable by default) would become a bit akward to use
>
> Why? It is not unusual at all that you need to specify certain extra
> parameters to export some kind of metadata. Isn't this just another
> example of that?

But you are talking about command line that simply don't work,
or do I misunderstand?

> Or are you worried that existing command lines won't work
> anymore without specifying the new flag?

That's also true afaict.

Carl Eugen