[FFmpeg-devel] [PATCH 2/2] fate/truehd: add a test for the truehd_core bitstream filter

[James Almer]

On 4/19/2020 4:01 PM, James Almer wrote:
> On 4/19/2020 2:57 PM, Andreas Rheinhardt wrote:
>> James Almer:
>>> On 4/19/2020 2:45 PM, Andreas Rheinhardt wrote:
>>>> James Almer:
>>>>> Signed-off-by: James Almer <jamrial at gmail.com>
>>>>> ---
>>>>>  tests/fate/truehd.mak | 5 +++++
>>>>>  1 file changed, 5 insertions(+)
>>>>>
>>>>> diff --git a/tests/fate/truehd.mak b/tests/fate/truehd.mak
>>>>> index 6c8b1220f1..e672716527 100644
>>>>> --- a/tests/fate/truehd.mak
>>>>> +++ b/tests/fate/truehd.mak
>>>>> @@ -8,5 +8,10 @@ fate-truehd-5.1-downmix-2.0: CMD = md5pipe -f truehd -request_channel_layout 2 -
>>>>>  fate-truehd-5.1-downmix-2.0: CMP = oneline
>>>>>  fate-truehd-5.1-downmix-2.0: REF = a269aee0051d4400c9117136f08c9767
>>>>>  
>>>>> +FATE_TRUEHD-$(call ALLYES, TRUEHD_DEMUXER TRUEHD_MUXER TRUEHD_CORE_BSF) += fate-truehd-core-bsf
>>>>> +fate-truehd-core-bsf: CMD = md5pipe -i $(TARGET_SAMPLES)/truehd/atmos.thd -c:a copy -bsf:a truehd_core -fflags +bitexact -f truehd
>>>>> +fate-truehd-core-bsf: CMP = oneline
>>>>> +fate-truehd-core-bsf: REF = 3aa5d0c7825051f3657b71fd6135183b
>>>>> +
>>>>>  FATE_SAMPLES_AUDIO += $(FATE_TRUEHD-yes)
>>>>>  fate-truehd: $(FATE_TRUEHD-yes)
>>>>>
>>>> Sure about the requirements? The truehd demuxer uses
>>>> ff_raw_read_packet_partial() to read packets, so I expected to see the
>>>> parser among the requirements.
>>>
>>> Sure, i can add it. But it may be more correct to add the parser
>>> dependency to the demuxer in configure instead, like the DTS ones do.
>>
>> Yeah, that makes sense.
> 
> Done. Will push this test later if there are no objections.

Pushed.