[FFmpeg-devel] [PATCH 1/3] avcodec/iff: Fix invalid pointer intermediates in decode_deep_rle32()

Michael Niedermayer michael at niedermayer.cc
Thu Apr 23 00:18:53 EEST 2020


On Wed, Apr 22, 2020 at 08:07:21PM +1000, Peter Ross wrote:
> On Tue, Apr 21, 2020 at 12:03:39AM +0200, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/iff.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavcodec/iff.c b/libavcodec/iff.c
> > index acd6519b06..2e65e266d0 100644
> > --- a/libavcodec/iff.c
> > +++ b/libavcodec/iff.c
> > @@ -715,7 +715,7 @@ static void decode_deep_rle32(uint8_t *dst, const uint8_t *src, int src_size, in
> >  {
> >      const uint8_t *src_end = src + src_size;
> >      int x = 0, y = 0, i;
> > -    while (src + 5 <= src_end) {
> > +    while (src_end - src >= 5) {
> >          int opcode;
> >          opcode = *(int8_t *)src++;
> >          if (opcode >= 0) {
> > -- 
> > 2.17.1
> 
> looks good. please apply.

will apply

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200422/9182bf55/attachment.sig>


More information about the ffmpeg-devel mailing list