[FFmpeg-devel] [PATCH 2/3] oggdec: verify page checksum

Lynne dev at lynne.ee
Tue Apr 28 20:22:08 EEST 2020


Apr 28, 2020, 16:07 by dev at lynne.ee:

> Apr 28, 2020, 15:59 by mattias.wadman at gmail.com:
>
>>
>>
> Well, I consider CRC checking a part of correctly parsing ogg, so I think its best to leave it on
> all the time.
>

Did a new version of the patches.
The first two are identical, save for some minor style tweaks.
The last one now ensures the max page size, 65k, is available for seeking and speeds up
decoding on new/replacement streams since the offset was incorrect.
I think its worth it.

I'm also close to figuring out how to make chained Opus work, will send a patch once I do.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-oggdec-eliminate-copies-and-extra-buffers.patch
Type: text/x-patch
Size: 6179 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200428/c268e2a3/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-oggdec-verify-page-checksum.patch
Type: text/x-patch
Size: 3284 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200428/c268e2a3/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-oggdec-use-ffio_ensure_seekback-to-seek-back-on-inco.patch
Type: text/x-patch
Size: 4926 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200428/c268e2a3/attachment-0002.bin>


More information about the ffmpeg-devel mailing list