[FFmpeg-devel] [PATCH 1/2] test: hlsenc: Don't generate test data with -re

[Martin Storsjö]

On Mon, 3 Aug 2020, Michael Niedermayer wrote:

> On Sun, Aug 02, 2020 at 11:38:51PM +0300, Martin Storsjö wrote:
>> This parameter artificially throttled the generation of the test sample
>> to take 5 seconds.
>> ---
>>  tests/fate/hlsenc.mak | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/fate/hlsenc.mak b/tests/fate/hlsenc.mak
>> index dce1f377c7..3c767fd5d9 100644
>> --- a/tests/fate/hlsenc.mak
>> +++ b/tests/fate/hlsenc.mak
>> @@ -88,7 +88,7 @@ fate-hls-list-size: CMD = framecrc -flags +bitexact -i $(TARGET_PATH)/tests/data
>>  tests/data/hls_fmp4.m3u8: TAG = GEN
>>  tests/data/hls_fmp4.m3u8: ffmpeg$(PROGSSUF)$(EXESUF) | tests/data
>>  	$(M)$(TARGET_EXEC) $(TARGET_PATH)/$< \
>> -	-f lavfi -re -i "aevalsrc=cos(2*PI*t)*sin(2*PI*(440+4*t)*t):d=5" -map 0 -codec:a mp2fixed \
>> +	-f lavfi -i "aevalsrc=cos(2*PI*t)*sin(2*PI*(440+4*t)*t):d=5" -map 0 -codec:a mp2fixed \
>
> is this removing the only test which tests the "-re" flag ?
> if so that would reduce test coverage

Well, tehcnically yes, but this test doesn't actually test whether the 
"-re" flag does what it's supposed to or anything like that - it only 
tests that adding the flag doesn't error out and doesn't alter the output. 
And it looks very much unintentional here.

// Martin