[FFmpeg-devel] [PATCH] Increasing the max length of control URI to 2048 characters, as urls of some RTSP streams do exceed this limit.

[Yiğit (Yeet) Uyan]

Hey Zhilizhao,

The RTSPState you mentioned is ok, but we need to get the char control_uri
buffer from 1024 characters to 2048. Some of the long rtsps links are
getting cut, and cannot play. Can you help getting this patch to the next
version? The patch does not show up in https://patchwork.ffmpeg.org/ at the
moment.

*•  **Yiğit (Yeet) Uyan*
*•*  Smart Home Intelligence | Google Home
*•*  yigituyan at google.com



On Wed, Aug 5, 2020 at 7:58 PM zhilizhao <quinkblack at foxmail.com> wrote:

>
>
> > On Aug 6, 2020, at 10:46 AM, zhilizhao <quinkblack at foxmail.com> wrote:
> >
> >
> >
> >> On Aug 6, 2020, at 6:38 AM, Yiğit (Yeet) Uyan <
> yigituyan-at-google.com at ffmpeg.org> wrote:
> >>
> >> Hello everyone,
> >>
> >> This is the first time for me to send a patch via email. Is this the
> >> correct format?
> >>
> >> I would appreciate it if someone could confirm, and if there is anything
> >> else I need to do to get it into upcoming releases.
> >>
> >> Best,
> >>
> >> *•  **Yiğit (Yeet) Uyan*
> >> *•*  Smart Home Intelligence | Google Home
> >> *•*  yigituyan at google.com
> >>
> >>
> >>
> >> On Wed, Aug 5, 2020 at 11:30 AM <device.access.test at gmail.com> wrote:
> >>
> >>> From: Yiğit (Yeet) Uyan <yigituyan at google.com>
> >>>
> >>> Signed-off-by: Yiğit (Yeet) Uyan <yigituyan at google.com>
> >>> ---
> >>> libavformat/rtsp.h | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/libavformat/rtsp.h b/libavformat/rtsp.h
> >>> index 54a9a30c16..2b37f5b49f 100644
> >>> --- a/libavformat/rtsp.h
> >>> +++ b/libavformat/rtsp.h
> >>> @@ -315,7 +315,7 @@ typedef struct RTSPState {
> >>>    /** some MS RTSP streams contain a URL in the SDP that we need to
> use
> >>>     * for all subsequent RTSP requests, rather than the input URI; in
> >>>     * other cases, this is a copy of AVFormatContext->filename. */
> >>> -    char control_uri[1024];
> >>> +    char control_uri[2048];
> >
> > There is a control_url field in RTSPState, and there are string copy
> between them.
>
> My copy-paste error: RTSPState -> RTSPStream.
>
> > This patch makes them have different length. Please check every usecase
> of the
> > field.
> >
> >>>
> >>>    /** The following are used for parsing raw mpegts in udp */
> >>>    //@{
> >>>
> >> _______________________________________________
> >> ffmpeg-devel mailing list
> >> ffmpeg-devel at ffmpeg.org
> >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>
> >> To unsubscribe, visit link above, or email
> >> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".