[FFmpeg-devel] [PATCH v2 3/5] avformat/dump: dump AV_PKT_DATA_MPEGTS_6A_DESC side data

[lance.lmwang at gmail.com]

On Fri, Aug 07, 2020 at 08:39:31AM +0200, Moritz Barsnick wrote:
> On Thu, Jul 30, 2020 at 22:58:56 +0800, lance.lmwang at gmail.com wrote:
> >  #include "libavutil/dovi_meta.h"
> > +#include "libavutil//mpegts_audio_desc_metadata.h"
>                       ^^
> A duplicate slash slipped in there.

Good catch, will fix it if patch will update.

> 
> > +    av_log(ctx, AV_LOG_INFO, "component_type_flag: %u, bsid_flag: %u, "
> > +           "mainid_flag: %u, asvc_flag: %u, "
> > +           "component_type: %u, bsid: %u, mainid: %u, asvc: %u",
> > +           desc6a->component_type_flag, desc6a->bsid_flag,
> > +           desc6a->mainid_flag, desc6a->asvc_flag,
> > +           desc6a->component_type, desc6a->bsid, desc6a->mainid, desc6a->asvc);
> > +}
> 
> Would it be more correct to just dump the actually existing values,
> i.e. those whose flag is 1? (I understand the flags say whether the
> value exists. What is printed for the value if it doesn't exist?)

Sure, it's more correct to print these field which is flag as 1. I consider it's 
more helpful to print the sample rate, channel nuber etc by those field map. But
it'll add more code for the mapping, so I choose to print it only.

> 
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

-- 
Thanks,
Limin Wang