[FFmpeg-devel] [PATCH 6/6] Revert "lavfi/avfiltergraph: add check before free the format"
Andreas Rheinhardt
andreas.rheinhardt at gmail.com
Sat Aug 8 17:02:03 EEST 2020
This reverts commit f156f4ab2317f22bfef33c7eaead0d5d5f162903.
The checks added by said commit are nonsense because they did not help
in case ff_merge_samplerates() or ff_merge_formats() returned NULL
while freeing one of its arguments: Said freeing does not change
the local variables of can_merge_formats().
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
---
libavfilter/avfiltergraph.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c
index 2fe4f0b0f9..a149f8fb6d 100644
--- a/libavfilter/avfiltergraph.c
+++ b/libavfilter/avfiltergraph.c
@@ -419,10 +419,8 @@ static int can_merge_formats(AVFilterFormats *a_arg,
av_freep(&ret);
return 1;
} else {
- if (a)
- av_freep(&a->formats);
- if (b)
- av_freep(&b->formats);
+ av_freep(&a->formats);
+ av_freep(&b->formats);
av_freep(&a);
av_freep(&b);
return 0;
--
2.20.1
More information about the ffmpeg-devel
mailing list