[FFmpeg-devel] [PATCH v4] avformat/mxfdec: Read video range from PictureDescriptor

[Tomas Härdin]

tor 2020-08-13 klockan 22:21 +0200 skrev Marton Balint:
> 
> On Thu, 13 Aug 2020, Tomas Härdin wrote:
> 
> > tor 2020-08-13 klockan 11:04 +0100 skrev Harry Mallon:
> > > Here is an updated patch (now hopefully going with correct email headers).
> > 
> > It would be nice if in the future you either attach the patch or make
> > the entire email the patch itself. I've had to trim these first couple
> > of lines in each of the patches so far, after doing "git am" on the
> > .mbox from saving your messages
> > 
> > > From 5866d0dc5536a6ea3f6a899c3d09f19df083c16a Mon Sep 17 00:00:00 2001
> > > 
> > > From: Harry Mallon <harry.mallon at codex.online>
> > > Date: Wed, 12 Aug 2020 10:26:23 +0100
> > > Subject: [PATCH v4] avformat/mxfdec: Read video range from PictureDescriptor
> > > 
> > > * Capture black_ref, white_ref and color_range and recognise
> > >   full and narrow range.
> > > 
> > > Signed-off-by: Harry Mallon <harry.mallon at codex.online>
> > > ---
> > >  libavformat/mxfdec.c           | 29 +++++++++++++++++++++++++++++
> > >  tests/ref/fate/mxf-probe-dnxhd |  2 +-
> > >  tests/ref/fate/mxf-probe-dv25  |  2 +-
> > >  3 files changed, 31 insertions(+), 2 deletions(-)
> > 
> > Looks good to me. Running FATE atm, will push in a day if there are no
> > objections.
> 
> http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket4328/01_Bad_Frame_2.24.mxf 
> is not detected correctly for some reason.
> 
> The MXF specs seems ambigous:
> 
> Color Range is a Property, whose unsigned 32-bit integer value shall 
> specify the number of distinct values allowed for color difference 
> samples.
> 
> So probably 2^depth color range should also be accepted as full range.

This sounds correct. Do we have any sample using 2^depth-1? If not then
we should just go with 2^depth until such a sample emerges.

/Tomas