[FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

[Paul B Mahol]

On 8/15/20, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Fri, Aug 14, 2020 at 02:24:25PM +0200, Paul B Mahol wrote:
>> On 8/14/20, Paul B Mahol <onemda at gmail.com> wrote:
>> > On 8/13/20, Paul B Mahol <onemda at gmail.com> wrote:
>> >> Hi,
>> >>
>> >> patch attached.
>> >>
>> >> Please review and/or benchmark, especially .asm file.
>> >>
>> >
>> > Updated patch attached.
>> >
>>
>> Sorry, wrong patch.
>>
>> New patch attached.
>
>>  Makefile           |    2
>>  cfhd.c             |  271
>> +++++++++++------------------------------------------
>>  cfhd.h             |    3
>>  cfhddsp.c          |  110 +++++++++++++++++++++
>>  cfhddsp.h          |   42 ++++++++
>>  x86/Makefile       |    2
>>  x86/cfhddsp.asm    |  227 ++++++++++++++++++++++++++++++++++++++++++++
>>  x86/cfhddsp_init.c |   44 ++++++++
>>  8 files changed, 488 insertions(+), 213 deletions(-)
>> 9312085fc5971774cdc8511019fa4023cf269100
>> 0001-avcodec-cfhd-add-x86-SIMD.patch
>> From 874fd9e604a6dcd55cca77c7256a633e5739da77 Mon Sep 17 00:00:00 2001
>> From: Paul B Mahol <onemda at gmail.com>
>> Date: Sun, 9 Aug 2020 17:47:34 +0200
>> Subject: [PATCH] avcodec/cfhd: add x86 SIMD
>
> This changes the fate checksums here
>

Are you sure you tested latest patch?

> --- ./tests/ref/fate/cfhd-1	2020-08-11 11:19:05.927726152 +0200
> +++ tests/data/fate/cfhd-1	2020-08-15 19:23:24.709365401 +0200
> @@ -3,13 +3,13 @@
>  #codec_id 0: rawvideo
>  #dimensions 0: 720x480
>  #sar 0: 0/1
> -0,          0,          0,        1,  1382400, 0xa3e49817
> -0,          1,          1,        1,  1382400, 0x544fdfac
> -0,          2,          2,        1,  1382400, 0x84964e11
> -0,          3,          3,        1,  1382400, 0xc608c8d1
> -0,          4,          4,        1,  1382400, 0xf2f1404f
> -0,          5,          5,        1,  1382400, 0x5a3100ba
> -0,          6,          6,        1,  1382400, 0x3727baa9
> -0,          7,          7,        1,  1382400, 0x894f07db
> -0,          8,          8,        1,  1382400, 0x3ef27d46
> -0,          9,          9,        1,  1382400, 0x1f90880d
> +0,          0,          0,        1,  1382400, 0x7267a5b0
> +0,          1,          1,        1,  1382400, 0xe9fec998
> +0,          2,          2,        1,  1382400, 0xd8883a69
> +0,          3,          3,        1,  1382400, 0x756dce7c
> +0,          4,          4,        1,  1382400, 0x349b63a2
> +0,          5,          5,        1,  1382400, 0x0fa92a41
> +0,          6,          6,        1,  1382400, 0x1d21d79c
> +0,          7,          7,        1,  1382400, 0x327d17af
> +0,          8,          8,        1,  1382400, 0xaa987c63
> +0,          9,          9,        1,  1382400, 0xab136e70
> Test cfhd-1 failed. Look at tests/data/fate/cfhd-1.err for details.
> tests/Makefile:255: recipe for target 'fate-cfhd-1' failed
> make: *** [fate-cfhd-1] Error 1
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Modern terrorism, a quick summary: Need oil, start war with country that
> has oil, kill hundread thousand in war. Let country fall into chaos,
> be surprised about raise of fundamantalists. Drop more bombs, kill more
> people, be surprised about them taking revenge and drop even more bombs
> and strip your own citizens of their rights and freedoms. to be continued
>