[FFmpeg-devel] [PATCH v5 3/5] lavc/avs3_parser: add avs3 parser

[hwren]

At 2020-08-19 22:14:04, "Moritz Barsnick" <barsnick at gmx.net> wrote:
>On Wed, Aug 19, 2020 at 14:25:54 +0800, hwrenx at 126.com wrote:
>> +        for (; cur < buf_size; ++cur) {
>> +            state = (state << 8) | buf[cur];
>> +            if (ISPIC(buf[cur])){
>> +                ++cur;
>
>ffmpeg prefers the "cur++" style (twice in this block, and elsewhere).

Will be corrected. Thanks.

>
>> +            // Skip bits: resv(1)
>> +            //            bitrate_low(18)
>> +            //            resv(1)
>> +            //            bitrate_high(12)
>> +            //            low_delay
>> +            skip_bits(&gb, 32);
>
>Is "low_delay" part of the skipped bits? The rest already adds up to
>32.

No it's not...The low_delay is added by mistake. I will remove it in the next version.

>
>> +            av_log(avctx, AV_LOG_DEBUG,
>> +                       "avs3 parse seq hdr: profile %d; coded wxh: %dx%d; "
>> +                       "frame_rate_code %d\n", profile, avctx->width, avctx->height, ratecode);
>
>Incorrect indentation.

Will be corrected. Thanks.

Cheers,
Huiwen Ren

>
>Cheers,
>Moritz
>_______________________________________________
>ffmpeg-devel mailing list
>ffmpeg-devel at ffmpeg.org
>https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>To unsubscribe, visit link above, or email
>ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".