[FFmpeg-devel] [RFC PATCH 3/4] libavcodec/jpeg2000: Modify cleanup

[Moritz Barsnick]

On Wed, Aug 19, 2020 at 17:51:01 +0530, gautamramk at gmail.com wrote:
> From: Gautam Ramakrishnan <gautamramk at gmail.com>
>
> This patch makes the ff_jpeg2000_cleanup
> function take in an extra parameter which
> indicates whether it is called from the
> encoder or decoder.

I fail to see an explanation why, ...

> -void ff_jpeg2000_cleanup(Jpeg2000Component *comp, Jpeg2000CodingStyle *codsty)
> +void ff_jpeg2000_cleanup(Jpeg2000Component *comp, Jpeg2000CodingStyle *codsty, int isencoder)
>  {
>      int reslevelno, bandno, precno;
>      for (reslevelno = 0;
> diff --git a/libavcodec/jpeg2000.h b/libavcodec/jpeg2000.h
> index ad58b1ae88..fee9607e86 100644
> --- a/libavcodec/jpeg2000.h
> +++ b/libavcodec/jpeg2000.h

... and what it does with this change. Looks like an NOP from the patch
file alone.

Moritz