[FFmpeg-devel] [PATCH 1/2] ffmpeg: add disable_all_auto_conversion_filters option.

Nicolas George george at nsup.org
Thu Aug 20 20:49:33 EEST 2020


Alexander Strasser (12020-08-17):
> I think the pendulum can swing in both direction here. So the overall
> effect is not clear to me. E.g. one developer may think
> 
>     "hey what's this -> i need to fix it"
> 
> another might think
> 
>     "hey what's this -> better just copy and not look into it"
> 
> and a third might think
> 
>     "hey what's this -> just another idiosyncrasy :("

Fortunately, patches are not accepted without review: they will do that,
the reviewer will ask them to fix the test and re-submit.

> Here are some suggestions in no particular order:
> 
> * auto_conversion_filters (from Marton)

I can be ok with this one. I really dislike boolean options that default
to yes and have to be disabled with no, because it requires remembering
what the default is, but if that is what everybody else prefers.

> * lavfi_auto_conversion
> * lavfi_autoconv
> * lavfi_sample_format_conversion
> * lavfi_fmt_conversion (in reference to pix_fmt and sample_fmt)
> * lavfi_fmt_conv

The last three lack the "auto" bit. Explicit conversions are still
supported.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200820/9ec67950/attachment.sig>


More information about the ffmpeg-devel mailing list