[FFmpeg-devel] [PATCH] libavfilter/vf_overlay_cuda: Pass the main frame to the output if secondary frame is not available. now filter fails if secondary frame is not available due to e.g secondary source delay.

Nicolas George george at nsup.org
Fri Aug 21 12:54:29 EEST 2020


Alex Pokotilo (12020-08-21):
> From b3739e33fa04a9292dc6584bd2f31460aa53d478 Mon Sep 17 00:00:00 2001
> From: Alex Pokotilo <support at wmspanel.com>
> Date: Fri, 21 Aug 2020 09:14:37 +0000
> Subject: [PATCH] libavfilter/vf_overlay_cuda: Pass the main frame to the output if secondary frame is not
>  available. now filter fails if secondary frame is not available due to e.g secondary source delay.

Your Git commit message is badly formatted. The format is:

	context: short summary on one line

	After an empty line, details if necessary, on several lines and
	wrapped at a reasonable line length.

The fix may be correct, but your analysis of the problem does not prove
it. Unless there is a serious bug in framesync, it will not call
overlay_cuda_blend() without a secondary frame "due to e.g secondary
source delay.", it will only do so if the stream has not yet begun or
has ended.

Please give more details on the exact circumstances you observe the
issue.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200821/4e7ff2e9/attachment.sig>


More information about the ffmpeg-devel mailing list