[FFmpeg-devel] [PATCH v5 1/3] [RFC] lavc: add FLIF decoding support

[Paul B Mahol]

On 8/20/20, Anamitra Ghorui <aghorui at teknik.io> wrote:
> Hello,
>
> On Wed, 19 Aug 2020 21:05:41 +0200
> Paul B Mahol <onemda at gmail.com> wrote:
>
> [...]
>
>> >
>> >
>> > All these corrections have been made by me locally, but I would
>> > like to wait for some further review (self and otherwise) before
>> > posting again.
>>
>> Please make use of av_clip and FFMIN/FFMAX macros.
>>
>
> We have looked through the code again and have not been able to notice a
> situation where these macros will be required aside from where they are
> already used. They have been largely used in the transform code and
> sparsely used everywhere else. Can you please point to a portion where
> their use is warranted?

ff_bound_snap.

Also av_freep() is inconsistently used in code. You do not need to
check for NULL, prior to calling it.

>
> Thanks,
> Anamitra
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".