[FFmpeg-devel] [PATCH 3/3] avcodec/aacdec_template: log the element order before/after reordering

Michael Niedermayer michael at niedermayer.cc
Sat Aug 22 14:21:31 EEST 2020


On Sat, Aug 22, 2020 at 12:58:00AM +0300, Jan Ekström wrote:
> This was quite useful to verify that 22.2 got properly handled,
> among other things.
> ---
>  libavcodec/aacdec_template.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c
> index 63604d39fd..b9b9ae5324 100644
> --- a/libavcodec/aacdec_template.c
> +++ b/libavcodec/aacdec_template.c
> @@ -266,6 +266,22 @@ static int count_paired_channels(uint8_t (*layout_map)[3], int tags, int pos,
>      return num_pos_channels;
>  }
>  
> +static void log_e2c(int num, struct elem_to_channel e2c) {
> +    char buf[128] = { 0 };
> +
> +    av_get_channel_layout_string(buf, sizeof(buf), -1, e2c.av_position);
> +
> +    av_log(NULL, AV_LOG_DEBUG,

without the NULL contexts i agree that this should be usefull for debuging

with the NULL its only when there is less than 2 streams

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200822/f7c04834/attachment.sig>


More information about the ffmpeg-devel mailing list