[FFmpeg-devel] [PATCH] fftools: Accept more negative prefixes

[Mark Thompson]

On 21/08/2020 06:49, Moritz Barsnick wrote:
> On Thu, Aug 20, 2020 at 22:49:16 +0100, Mark Thompson wrote:
> 
>> With this patch, -disable_auto_conversion_filters does what you want.
> [...]
>> +    if (!po->name) {
>> +        /* Try to match a boolean option with a negative prefix. */
>> +        for (int i = 0; i < FF_ARRAY_ELEMS(negative_prefixes); i++) {
>> +            size_t len = strlen(negative_prefixes[i]);
>> +            if (!strncmp(opt, negative_prefixes[i], len)) {
>> +                po = find_option(options, opt + len);
>> +                if (po->name && (po->flags & OPT_BOOL)) {
>> +                    arg = "0";
>> +                    break;
>> +                }
>> +            }
>> +        }
> 
> Without checking in more detail: Wouldn't this break the
> "-noise_reduction", "-non_deterministic" and "-non_linear_quant"
> options?

The intent is to extend what already happens - given an argument like "-nougat", it first looks for the option of any kind called "nougat", then only if that is not found looks for a boolean option called "ugat".  In your example, the "noise_reduction" option is found, so "ise_reduction" is never searched for.

(Alternatively: if you are referencing a bug which you have spotted in my change but I am missing, could you explain in more detail?)

- Mark