[FFmpeg-devel] [PATCH 1/3] avcodec/cbs_av1: add derived frame size to AV1RawFrameHeader

[Mark Thompson]

On 23/08/2020 03:02, James Almer wrote:
> Same logic as tile_cols and tile_rows, this saves CBS users having to
> recalculate these values, and makes them available for all frames within a
> Temporal Unit.
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
> Not a fan of adding more derived values to "raw" structs, but much like the
> tile ones, these will be useful.

Perhaps it would be cleaner to avoid adding anything by inferring values for the existing frame_width_minus_1 / etc. fields in the cases where they aren't directly in the bitstream?  (In the same way the tile ones do.)

>   libavcodec/cbs_av1.h                 |  8 +++++++
>   libavcodec/cbs_av1_syntax_template.c | 32 ++++++++++++++--------------
>   2 files changed, 24 insertions(+), 16 deletions(-)
> 
> ...
- Mark