[FFmpeg-devel] [PATCH V2] dnn: move output name from DNNModel.set_input_output to DNNModule.execute_model

[Guo, Yejun]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Fu, Ting
> Sent: 2020年8月21日 18:01
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH V2] dnn: move output name from
> DNNModel.set_input_output to DNNModule.execute_model
> 
> 
> 
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Guo,
> > Yejun
> > Sent: Friday, August 21, 2020 01:34 PM
> > To: ffmpeg-devel at ffmpeg.org
> > Subject: [FFmpeg-devel] [PATCH V2] dnn: move output name from
> > DNNModel.set_input_output to DNNModule.execute_model
> >
> > currently, output is set both at DNNModel.set_input_output and
> > DNNModule.execute_model, it makes sense that the output name is
> > provided at model inference time so all the output info is set at a single place.
> >
> > and so DNNModel.set_input_output is renamed to DNNModel.set_input
> >
> > Signed-off-by: Guo, Yejun <yejun.guo at intel.com>
> > ---
> > v2: rebase with master
> >
> >  libavfilter/dnn/dnn_backend_native.c   | 44 +++++++----------
> >  libavfilter/dnn/dnn_backend_native.h   |  4 +-
> >  libavfilter/dnn/dnn_backend_openvino.c | 50 +++++--------------
> > libavfilter/dnn/dnn_backend_openvino.h |  2 +-
> >  libavfilter/dnn/dnn_backend_tf.c       | 87
> ++++++++++++++--------------------
> >  libavfilter/dnn/dnn_backend_tf.h       |  2 +-
> >  libavfilter/dnn_interface.h            |  4 +-
> >  libavfilter/vf_derain.c                |  6 +--
> >  libavfilter/vf_dnn_processing.c        |  9 ++--
> >  libavfilter/vf_sr.c                    | 11 +++--
> >  10 files changed, 82 insertions(+), 137 deletions(-)
> >
> [...]
> > --
> > 2.7.4
> 
> LGTM, all three backends(Native/TF/OV) function well.
> 
thanks for the test, will push tomorrow if no other comments.