[FFmpeg-devel] [PATCH 2/3] avcodec/cbs_av1: infer frame_type when parsing a show_existing_frame frame

[James Almer]

On 8/24/2020 4:57 AM, Xu, Guangxin wrote:
> May not related to this patch.
> When we have show_existing_frame and the frame_type is key frame, do we need do "Reference frame update"?

I think so, judging by Section 7.4 "Decode frame wrapup process", which
says that section 7.20 "Reference frame update process" should be called
after parsing a show_existing_frame frame.

In any case, this patch was done for the sake of giving the caller a
shortcut to read frame properties of the frame referenced by the
show_existing_frame frame_header if they needed to, but it was disliked
by Ronald, so I'll probably revert it as well as the other inferred
values in the previous patch.

> 
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of James
>> Almer
>> Sent: Monday, August 24, 2020 3:24 AM
>> To: ffmpeg-devel at ffmpeg.org
>> Subject: [FFmpeg-devel] [PATCH 2/3] avcodec/cbs_av1: infer frame_type when
>> parsing a show_existing_frame frame
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>>  libavcodec/cbs_av1_syntax_template.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/libavcodec/cbs_av1_syntax_template.c
>> b/libavcodec/cbs_av1_syntax_template.c
>> index dedd549572..28d9ab9817 100644
>> --- a/libavcodec/cbs_av1_syntax_template.c
>> +++ b/libavcodec/cbs_av1_syntax_template.c
>> @@ -1299,6 +1299,7 @@ static int
>> FUNC(uncompressed_header)(CodedBitstreamContext *ctx, RWContext *rw,
>>              else
>>                  infer(refresh_frame_flags, 0);
>>
>> +            infer(frame_type,            frame->frame_type);
>>              infer(frame_width_minus_1,   frame->upscaled_width - 1);
>>              infer(frame_height_minus_1,  frame->frame_height - 1);
>>              infer(render_width_minus_1,  frame->render_width - 1);
>> --
>> 2.27.0
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email ffmpeg-devel-request at ffmpeg.org
>> with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>