[FFmpeg-devel] [PATCH 3/3] tests/fate-run.sh: Don't overlook errors from md5 tests
Andreas Rheinhardt
andreas.rheinhardt at gmail.com
Sat Dec 5 00:57:40 EET 2020
The md5 test up until now ignored errors from ffmpeg (the cli) and just
md5'ed whatever ffmpeg has output; while testing scenarios in which
ffmpeg fails has its merits, errors should not be overlooked by default;
doing so also reduces the effectiveness of sanitizers as errors from
them are ignored. This has happened with a memleak in the AV1 decoder.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
---
tests/fate-run.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/fate-run.sh b/tests/fate-run.sh
index 58d5fdbb60..b69176f7c3 100755
--- a/tests/fate-run.sh
+++ b/tests/fate-run.sh
@@ -158,7 +158,7 @@ md5pipe(){
md5(){
encfile="${outdir}/${test}.out"
cleanfiles="$cleanfiles $encfile"
- ffmpeg -y "$@" $(target_path $encfile)
+ ffmpeg -y "$@" $(target_path $encfile) || return
do_md5sum $encfile | awk '{print $1}'
}
--
2.25.1
More information about the ffmpeg-devel
mailing list