[FFmpeg-devel] [PATCH v3] avcodec/libvpxenc: add a way to set VP9E_SET_SVC_REF_FRAME_CONFIG

[Wonkap Jang]

On Mon, Dec 21, 2020 at 1:40 PM James Zern <jzern at google.com> wrote:

> On Thu, Dec 17, 2020 at 2:43 PM Wonkap Jang <wonkap at google.com> wrote:
> >
> >
> >
> > On Thu, Dec 17, 2020 at 10:48 AM James Zern <jzern at google.com> wrote:
> >>
> >> On Tue, Dec 15, 2020 at 9:24 AM Wonkap Jang <wonkap at google.com> wrote:
> >> >
> >> > Hi James
> >> >
> >> > On Tue, Dec 15, 2020 at 9:18 AM Wonkap Jang <wonkap at google.com>
> wrote:
> >> >>
> >> >> In order to fine-control referencing schemes in VP9 encoding, there
> >> >> is a need to use VP9E_SET_SVC_REF_FRAME_CONFIG method. This commit
> >> >> provides a way to use the API through frame metadata.
> >> >> ---
> >> >>  doc/encoders.texi      | 32 +++++++++++++++++
> >> >>  libavcodec/libvpxenc.c | 81
> ++++++++++++++++++++++++++++++++++++++++++
> >> >>  2 files changed, 113 insertions(+)
> >> >>
> >> > [...]
> >> > In reply to your comment about using ABI_VERSION for guarding the
> changes, the reason I used the unrelated
>  "VPX_CTRL_VP9E_SET_MAX_INTER_BITRATE_PCT" is because the ABI_VERION did
> not seem to have changed between the last commit that you suggested
> (v1.7.0-936-g04b3d49ba) to use and the lateset libvpx version. Can you
> confirm this?
> >> >
> >>
> >> I think I may have mentioned, this doesn't have to be precise. You can
> >> just make 1.8.0 the baseline.
> >> Also it looks like you might have some syntax errors in encoders.texi.
> >> If you have the prerequisites, make doc can test the file locally.
> >>
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20201215171825.2598712-1-wonkap@google.com/
> >
> >
> > Hi James,
> >
> > Maybe my local setup has outdated codebase for the doc changes...weird
> because it is building without any problems... I even checked it with
> "texi2html" tool.
> > I'll try to fix the doc compile issue. But, I don't quite get what you
> mean by  "just make 1.8.0 the baseline".
> > What I was trying to get to was the fact that you wanted me to use
> VPX_ENCODER_ABI_VERSION instead of VPX_CTRL_VP9E_SET_MAX_INTER_BITRATE_PCT.
> > But, what I see is that VPX_ENCODER_ABI_VERSION has not changed even in
> the latest codebase. Are you suggesting something else by saying "just make
> 1.8.0 the baseline"?
> > Is there something I am missing? :)
> >
>
> It's possible I misread your earlier replies. I see what you mean, the
> abi version hasn't changed at all since then, though it should have.
> It will change in the next release, but this check is ok. We have some
> similar variants already.
>
> > Let me know,
> >
> > Thanks!!
> >
> > Wonkap
>

OK. then, I'll send out new changes. with updated code base.

Thanks,

Wonkap