[FFmpeg-devel] [PATCH] libavformat: add librist protocol

[Nicolas George]

Marton Balint (12020-12-23):
> > +static int librist_get_file_handle(URLContext *h)
> > +{
> > +    RISTContext *s = h->priv_data;
> > +
> > +    return s->fd;
> > +}
> 
> I don't think this is right, s->fd is a flow id, not an ordinary file
> descriptor. You probably don't need this callback anyway.

It is indeed not a file descriptor at all, returning it like that would
cause very serious bugs.

It seems this library does not make its file descriptors at all. It
means it cannot be used by FFmpeg in non-blocking mode, nor by any
application with a standard Unix event loop.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20201223/4f80f8f4/attachment.sig>