[FFmpeg-devel] [PATCH] avcodec/adpcm_argo: simplify and move duplicated logic into a function

[Zane van Iperen]

2/2/20 4:04 am, Michael Niedermayer пишет:
> 
> On Sat, Feb 01, 2020 at 06:59:59AM +0000, Zane van Iperen wrote:
>> Signed-off-by: Zane van Iperen <zane at zanevaniperen.com>
>> ---
>>   libavcodec/adpcm.c | 40 ++++++++++++++++++----------------------
>>   1 file changed, 18 insertions(+), 22 deletions(-)
> 
> it seems theres no fate test for adpcm_argo
> this patch looks ok but the codepath seems untested, maybe you can add a test ?
> 

I can. Would it best be send as a v2, or as a separate patch completely?

In the meantime, this patch doesn't break anything, as it passes my usual checks.
These are the files that gave the most grief when writing the decoder and I
know their expected hashes.

$ ./ffmpeg -loglevel error -i OUTRO.ASF -map 0:a -f md5 -
MD5=e0428a6c55382f48502f04b3a7f7b94b

$ ./ffmpeg -loglevel error -i CBK2.asf -map 0:a -f md5 -
MD5=589f3f3c518e5d58aa404b7576db5b70



> thx
> 
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> I am the wisest man alive, for I know one thing, and that is that I know
> nothing. -- Socrates
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> 

Zane