[FFmpeg-devel] [EXTREMELY IMPORTANT] [PLEASE DO NOT IGNORE] [PATCH] avfilter/framesync: do not pick AV_TIME_BASE for time base when not needed.

[Nicolas George]

Paul B Mahol (12020-02-02):
> Changing time base when all inputs have same time base seems strange
> and excessive to me.

This is true when the denominator is 500000, when it's 499999 and when
it's 500001. Expending efforts just for 500000 is not efficient,
especially since this one does not lead to a loss of precision.

> Is there something wrong with my patch or you just prefer status quo?

The current code seems more logical to me. Large round denominators are
a sign that the time base was not really rational in the first place.

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200202/8ee8658c/attachment.sig>