[FFmpeg-devel] [PATCH 3/4] avcodec/mlpdsp: Fix a invalid shift in ff_mlp_rematrix_channel()

[Michael Niedermayer]

On Sun, Feb 02, 2020 at 02:07:14PM +0530, Jai Luthra wrote:
> On Sun, Feb 02, 2020 at 01:16:38AM +0100, Michael Niedermayer wrote:
> >Fixes: left shift of negative value -2
> >Fixes: 20305/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEHD_fuzzer-5677196618498048
> >
> >Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> >Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> >---
> >libavcodec/mlpdsp.c | 2 +-
> >1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/libavcodec/mlpdsp.c b/libavcodec/mlpdsp.c
> >index 32a4503b64..12bef3a721 100644
> >--- a/libavcodec/mlpdsp.c
> >+++ b/libavcodec/mlpdsp.c
> >@@ -79,7 +79,7 @@ void ff_mlp_rematrix_channel(int32_t *samples,
> >
> >        if (matrix_noise_shift) {
> >            index &= access_unit_size_pow2 - 1;
> >-            accum += noise_buffer[index] << (matrix_noise_shift + 7);
> >+            accum += noise_buffer[index] * (1 << (matrix_noise_shift + 7));
> >            index += index2;
> >        }
> >
> >-- 
> >2.17.1
> >
> >_______________________________________________
> 
> 
> lgtm.

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Never trust a computer, one day, it may think you are the virus. -- Compn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200202/fd1896f0/attachment.sig>