[FFmpeg-devel] [PATCH v2] avcodec/h264_metadata_bsf: give warning when display_orientation set to EXTRACT

Steven Liu lq at chinaffmpeg.org
Sun Feb 9 16:17:23 EET 2020


Extraction of h264_metadata display_orientation not implemented yet.

Suggested-by: Gyan Doshi <ffmpeg at gyani.pro>
Signed-off-by: Steven Liu <lq at chinaffmpeg.org>
---
 libavcodec/h264_metadata_bsf.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c
index d96a50dbf7..89b8d01679 100644
--- a/libavcodec/h264_metadata_bsf.c
+++ b/libavcodec/h264_metadata_bsf.c
@@ -438,6 +438,9 @@ static int h264_metadata_filter(AVBSFContext *bsf, AVPacket *pkt)
     }
 
     if (ctx->display_orientation != PASS) {
+        if (ctx->display_orientation == EXTRACT)
+            av_log(bsf, AV_LOG_WARNING, "Extraction of h264_metadata display_orientation not implemented.\n");
+
         for (i = au->nb_units - 1; i >= 0; i--) {
             H264RawSEI *sei;
             if (au->units[i].type != H264_NAL_SEI)
-- 
2.15.1





More information about the ffmpeg-devel mailing list