[FFmpeg-devel] [PATCH 02/11] avformat: Remove unnecessary av_packet_unref()

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Sun Feb 9 19:57:35 EET 2020


On Tue, Jan 21, 2020 at 9:51 PM Andreas Rheinhardt <
andreas.rheinhardt at gmail.com> wrote:

> On Mon, Jan 13, 2020 at 4:45 PM Andreas Rheinhardt <
> andreas.rheinhardt at gmail.com> wrote:
>
>> On Tue, Jan 7, 2020 at 2:56 PM Andreas Rheinhardt <
>> andreas.rheinhardt at gmail.com> wrote:
>>
>>> Since bae8844e the packet will always be unreferenced when a demuxer
>>> returns an error, so that a lot of calls to av_packet_unref() in lots of
>>> demuxers are now redundant and can be removed.
>>>
>>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
>>> ---
>>>  libavformat/aacdec.c         |  6 ------
>>>  libavformat/adp.c            |  1 -
>>>  libavformat/adxdec.c         |  2 --
>>>  libavformat/amr.c            |  1 -
>>>  libavformat/ape.c            |  1 -
>>>  libavformat/avs.c            |  1 -
>>>  libavformat/brstm.c          |  3 +--
>>>  libavformat/c93.c            | 13 +++----------
>>>  libavformat/cdxl.c           |  1 -
>>>  libavformat/concatdec.c      |  4 +---
>>>  libavformat/dfa.c            |  3 ---
>>>  libavformat/dsicin.c         |  1 -
>>>  libavformat/dss.c            |  6 +-----
>>>  libavformat/dxa.c            |  1 -
>>>  libavformat/electronicarts.c |  3 ---
>>>  libavformat/fitsdec.c        |  2 --
>>>  libavformat/flic.c           |  3 +--
>>>  libavformat/g723_1.c         |  1 -
>>>  libavformat/gdv.c            |  1 -
>>>  libavformat/gsmdec.c         |  1 -
>>>  libavformat/hls.c            |  1 -
>>>  libavformat/icodec.c         |  1 -
>>>  libavformat/idcin.c          |  2 --
>>>  libavformat/idroqdec.c       |  3 +--
>>>  libavformat/ilbc.c           |  1 -
>>>  libavformat/img2dec.c        |  1 -
>>>  libavformat/iv8.c            |  1 -
>>>  libavformat/libmodplug.c     |  1 -
>>>  libavformat/lxfdec.c         |  1 -
>>>  libavformat/mov.c            |  1 -
>>>  libavformat/mpc.c            |  1 -
>>>  libavformat/mpegts.c         |  1 -
>>>  libavformat/mpjpegdec.c      |  2 --
>>>  libavformat/ncdec.c          |  1 -
>>>  libavformat/nuv.c            |  1 -
>>>  libavformat/oggdec.c         |  7 ++-----
>>>  libavformat/redspark.c       |  1 -
>>>  libavformat/rl2.c            |  1 -
>>>  libavformat/rpl.c            |  2 --
>>>  libavformat/s337m.c          |  2 --
>>>  libavformat/sapdec.c         |  1 -
>>>  libavformat/sdr2.c           |  1 -
>>>  libavformat/sierravmd.c      |  1 -
>>>  libavformat/siff.c           |  1 -
>>>  libavformat/spdifdec.c       |  5 +----
>>>  libavformat/swfdec.c         |  3 ---
>>>  libavformat/thp.c            |  2 --
>>>  libavformat/vivo.c           | 14 +++++---------
>>>  libavformat/vpk.c            |  4 +---
>>>  libavformat/vqf.c            |  1 -
>>>  libavformat/wvdec.c          |  4 ----
>>>  libavformat/yuv4mpegdec.c    |  1 -
>>>  52 files changed, 17 insertions(+), 108 deletions(-)
>>>
>>>
>> Ping for this and the other open patches (namely #1, #2, #5 and #9) of
>> this patchset. If it is deemed to help reviewing I can split this patch
>> per-file.
>>
>> - Andreas
>>
>> Another ping. As has been said, I am open to splitting this per-file.
>
> - Andreas
>

Will send a version split-by-file tomorrow.

- Andreas


More information about the ffmpeg-devel mailing list