[FFmpeg-devel] [PATCH] lavf: stop filtering side data in mkv

[Michael Bradshaw]

On Mon, Feb 10, 2020 at 1:22 PM Andreas Rheinhardt <
andreas.rheinhardt at gmail.com> wrote:

> 1. This partially overlaps and partially conflicts with [2].
>

Thanks. I'll wait for [2] to be merged and then will update the patch to be
WebM-specific.

2. The patch as-is is dangerous: There is currently no check that the size
> of the BlockAdditions-side-data is at least eight
>

That's a pre-existing bug, but yes, it's worth fixing and I'll wait for [2]
to be merged.

3. Anyway, your patch would allow to write BlockAdditions with a BlockAddID
> of zero, although that value is illegal.


I'll update the patch to prevent that, thanks.

I'll re-send the patch once [2] is merged.