[FFmpeg-devel] [PATCH 1/3] avutil/frame: add use_last_roi

[James Almer]

On 2/14/2020 5:33 AM, Hendrik Leppkes wrote:
> On Fri, Feb 14, 2020 at 4:41 AM Guo, Yejun <yejun.guo at intel.com> wrote:
>>
>> For some cases, the regions of interest do not change, it is not
>> convenient to always prepare the roi data for every frame. So, add
>> use_last_roi to show it uses the same roi data as last frame.
>>
>> Since a new flag is added into AVFrame, the major version number of
>> lavu is changed.
>>
> 
> Changing the major version for a field addition is not acceptable, it
> should be added to the end and not require that. Furthermore, I feel
> like the entire presence of that field in AVFrame is not a good idea.
> Its a very specific field, and we actively tried to remove such fields
> from the very generic structures like AVFrame, using side-data and
> other feature/codec-specific things instead. ROI itself is side-data,
> so this flag should be as well.

This new field is also not acceptable because, same as the disposable
flag i wanted to add some time ago, it is not really an attribute of a
frame in itself, but of a frame in a frame chain.

> 
> - Hendrik
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>