[FFmpeg-devel] [PATCH 1/2] avformat/utils: avoid unsigned integer overflows

Marton Balint cus at passwd.hu
Sat Feb 15 18:29:48 EET 2020



On Sat, 15 Feb 2020, Paul B Mahol wrote:

> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
> libavformat/utils.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavformat/utils.c b/libavformat/utils.c
> index 81ea239a66..ba2621aa28 100644
> --- a/libavformat/utils.c
> +++ b/libavformat/utils.c
> @@ -4450,10 +4450,12 @@ void avformat_free_context(AVFormatContext *s)
>     if (s->oformat && s->oformat->priv_class && s->priv_data)
>         av_opt_free(s->priv_data);
> 
> +    if (s->nb_streams)
>     for (i = s->nb_streams - 1; i >= 0; i--)

Maybe rewrite the loop instead?
       for (i = s->nb_streams; i-- > 0;)

Regards,
Marton

>         ff_free_stream(s, s->streams[i]);
> 
> 
> +    if (s->nb_programs)
>     for (i = s->nb_programs - 1; i >= 0; i--) {
>         av_dict_free(&s->programs[i]->metadata);
>         av_freep(&s->programs[i]->stream_index);
> -- 
> 2.17.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list