[FFmpeg-devel] [PATCH 4/4] swscale/output: Fix integer overflow in alpha computation in yuv2gbrp16_full_X_c()

Michael Niedermayer michael at niedermayer.cc
Sun Feb 16 21:43:03 EET 2020


Fixes: signed integer overflow: 524280 * 4432 cannot be represented in type 'int'
Fixes: ticket8322

Found-by: Suhwan
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libswscale/output.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libswscale/output.c b/libswscale/output.c
index 04595d2d01..68f43ffba3 100644
--- a/libswscale/output.c
+++ b/libswscale/output.c
@@ -2278,7 +2278,7 @@ yuv2gbrp16_full_X_c(SwsContext *c, const int16_t *lumFilter,
             A = -0x40000000;
 
             for (j = 0; j < lumFilterSize; j++)
-                A += alpSrc[j][i] * lumFilter[j];
+                A += alpSrc[j][i] * (unsigned)lumFilter[j];
 
             A >>= 1;
             A += 0x20002000;
-- 
2.17.1



More information about the ffmpeg-devel mailing list