[FFmpeg-devel] [PATCH 1/3 v2] avcodec: add an AVCodecContext field to signal types of packet, frame, and coded stream side data to export

Anton Khirnov anton at khirnov.net
Wed Feb 19 15:36:14 EET 2020


Quoting James Almer (2020-02-13 20:42:48)
> On 2/10/2020 3:26 PM, James Almer wrote:
> > Add an initial mvs flag to is, analog to the export_mvs flags2 one.
> > 
> > Signed-off-by: James Almer <jamrial at gmail.com>
> > ---
> >  libavcodec/avcodec.h                 | 18 ++++++++++++++++++
> >  libavcodec/mpegpicture.c             |  2 +-
> >  libavcodec/mpegutils.c               |  2 +-
> >  libavcodec/options_table.h           |  2 ++
> >  libavcodec/snowdec.c                 |  2 +-
> >  libavcodec/utils.c                   |  3 +++
> >  tests/ref/fate/api-mjpeg-codec-param |  2 ++
> >  tests/ref/fate/api-png-codec-param   |  2 ++
> >  8 files changed, 30 insertions(+), 3 deletions(-)
> 
> No opinions about the field or constant names?
> 
> An alternative is to add one field per type of side data instead of
> dumping them all in one. So packet, frame and coded stream. The latter
> would be added once it's needed, or added now and the CPB properties
> side data could be made optional through it (although i don't like
> disabling it by default when it's been enabled for a long time now).

That seems like overkill to me. The set looks good as it is.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list