[FFmpeg-devel] [PATCH] swscale/x86/yuv2rgb: Fix build without SSSE3

Hendrik Leppkes h.leppkes at gmail.com
Sun Feb 23 19:39:37 EET 2020


On Sun, Feb 23, 2020 at 6:26 PM Paul B Mahol <onemda at gmail.com> wrote:
>
> On 2/23/20, James Almer <jamrial at gmail.com> wrote:
> > On 2/23/2020 9:33 AM, Paul B Mahol wrote:
> >> lgtm
> >
> > No, it's not ok. The EXTERNAL_SSSE3() macro should be enough to prevent
> > any of these functions from running on old CPUs.
>
> this is about building.
>

We don't protect other parts of the SIMD code with preprocessor
checks, we only typically do it for AVX2, but not any of the SSE
variants, so at the very least some clarity would be appreciated why
and when this is needed. Because the commit message does not.

- Hendrik


More information about the ffmpeg-devel mailing list