[FFmpeg-devel] [PATCH 1/2] lavc/qsvdec: add decode support for HEVC 4:2:2 8-bit and 10-bit

[Fu, Linjie]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Mark Thompson
> Sent: Wednesday, February 26, 2020 06:59
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavc/qsvdec: add decode support
> for HEVC 4:2:2 8-bit and 10-bit
> 
> On 25/02/2020 02:01, Linjie Fu wrote:
> > Enables HEVC Range Extension decoding support for 4:2:2 8/10 bit
> > on ICL+ (gen11 +) platform.
> >
> > Signed-off-by: Linjie Fu <linjie.fu at intel.com>
> > ---
> >  libavcodec/qsv.c          | 12 ++++++++++++
> >  libavutil/hwcontext_qsv.c | 22 ++++++++++++++++++++++
> >  2 files changed, 34 insertions(+)
> 
> Should this be gated somehow to stop it being run on Windows?  There it will
> probably fail in some ugly way inside the D3D code which doesn't support
> YUYV formats.

Yes, thanks for pointing this out,  fixed and verified on windows, no crash observed anymore
in the D3D path for windows.

> Similarly, do you need a specific libva version or is that already implied by the
> libmfx version?

IMHO it's implied by libmfx version already.
A successfully built MSDK with API version > 1.27 should have supported VA_FOURCC_Y210 [1] in libva.

[1] https://github.com/Intel-Media-SDK/MediaSDK/blob/master/_studio/shared/src/libmfx_allocator_vaapi.cpp#L87

Thanks,

- Linjie