[FFmpeg-devel] [PATCH] [RFC] GSoC: FLIF16 Image format parser

[Moritz Barsnick]

Welcome to ffmpeg!

Since review has now started, I want to point out what was missed:

On Wed, Feb 26, 2020 at 12:26:37 +0530, Anamitra Ghorui wrote:

> a. Please tell me if I am right or wrong here:
> 1. Each audio/video/image file format has a parser for converting the
>    file data into a format that can be understood by a decoder.
>
> 2. A Decoder converts a given, recogised encoded data stream into a
>    form that can be processed by physical hardware.
>
> 3. File formats can be independent of what sort of encoding it uses.
>    Eg: WebM

Welcome to the world of multimedia. For many (but not all)
contributions, it is important to understand these concepts. Do play
around with ffmpeg and perhaps some examples from the ffmpeg wiki. And
feel free to ask. :-)

Also observe the contribution flow on this mailing list. Your mentor
will assist you though, because not everything may be obvious enough.

>  libavcodec/Makefile        |  1 +
>  libavcodec/avcodec.h       |  1 +
>  libavcodec/flif16_parser.c | 51 ++++++++++++++++++++++++++++++++++++++
>  libavcodec/parsers.c       |  1 +
>  libavformat/img2.c         |  1 +
>  5 files changed, 55 insertions(+)
>  create mode 100644 libavcodec/flif16_parser.c

Just to jump ahead: As soon as you start an actual decoder and demuxer,
you will ultimately (i.e. in a future version, before push) require:

- a Changelog entry (as soo
- documentation in doc/*.texi
- a minor version bump of libavcodec (or libavformat, with the commit
  in which each gains a new codec/format), resetting micro to 100

>  OBJS-$(CONFIG_FLAC_PARSER)             += flac_parser.o flacdata.o flac.o \
>                                            vorbis_data.o
> +OBJS-$(CONFIG_FLAC_PARSER)             += flif16_parser.o
                 ^^^^

This looks wrong. You are adding this object to a compile of the FLAC
parser, not your new parser. (Probably a copy/paste mistake.)

Cheers,
Moritz