[FFmpeg-devel] [PATCH 1/1] Patch for adding Documentation of ff_http_match_no_proxy

[Michael Niedermayer]

On Sat, Feb 29, 2020 at 05:07:30PM +0530, Sourabh Sharma wrote:
> Patch for adding Documentation of ff_http_match_no_proxy
> 
> Function ff_http_match_no_proxy check for host of proxy address
> matches with hostname or not.
> ---
>  libavformat/network.h | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/libavformat/network.h b/libavformat/network.h
> index 71347e815b..cd533a7cbc 100644
> --- a/libavformat/network.h
> +++ b/libavformat/network.h
> @@ -302,7 +302,13 @@ int ff_accept(int fd, int timeout, URLContext *h);
>  int ff_listen_connect(int fd, const struct sockaddr *addr,
>                        socklen_t addrlen, int timeout,
>                        URLContext *h, int will_try_next);
> -

> +/**
> + * It Check for host of proxy address matches with hostname or not.

This has some english grammer issues.
Also look at how other similar function doxy is worded


> + *
> + * @param no_proxy URL of proxy address
> + * @param hostname URL of hostname

I dont think the function would be understood from just this


thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Does the universe only have a finite lifespan? No, its going to go on
forever, its just that you wont like living in it. -- Hiranya Peiri
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200229/8c6a83a6/attachment.sig>