[FFmpeg-devel] [PATCH 04/11] avformat/fitsdec: Fix potential leak of string in AVBPrint

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Tue Jan 7 15:55:42 EET 2020


by freeing it a bit earlier.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
---
 libavformat/fitsdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/fitsdec.c b/libavformat/fitsdec.c
index e917fc2375..e52ddc7e79 100644
--- a/libavformat/fitsdec.c
+++ b/libavformat/fitsdec.c
@@ -157,11 +157,11 @@ static int fits_read_packet(AVFormatContext *s, AVPacket *pkt)
 
     av_bprint_init(&avbuf, FITS_BLOCK_SIZE, AV_BPRINT_SIZE_UNLIMITED);
     while ((ret = is_image(s, fits, &header, &avbuf, &size)) == 0) {
+        av_bprint_finalize(&avbuf, NULL);
         pos = avio_skip(s->pb, size);
         if (pos < 0)
             return pos;
 
-        av_bprint_finalize(&avbuf, NULL);
         av_bprint_init(&avbuf, FITS_BLOCK_SIZE, AV_BPRINT_SIZE_UNLIMITED);
         avpriv_fits_header_init(&header, STATE_XTENSION);
     }
-- 
2.20.1



More information about the ffmpeg-devel mailing list