[FFmpeg-devel] Patch "configure: Check for the SetDllDirectory and GetModuleHandle functions" by Martin Storsjö

[Jörg Beckmann]

Hi,

with this patch, FFmpeg does not compile for me on Cygwin anymore:

---------------------------------------
fftools/cmdutils.c: In function 'get_preset_file':
fftools/cmdutils.c:2043:22: error: 'MAX_PATH' undeclared (first use in this function); did you mean '_CS_PATH'?
         char datadir[MAX_PATH], *ls;
                      ^~~~~~~~
                      _CS_PATH
fftools/cmdutils.c:2043:22: note: each undeclared identifier is reported only once for each function it appears in
fftools/cmdutils.c:2046:13: error: implicit declaration of function 'GetModuleFileNameA' [-Werror=implicit-function-declaration]
         if (GetModuleFileNameA(GetModuleHandleA(NULL), datadir, sizeof(datadir) - 1))
             ^~~~~~~~~~~~~~~~~~
fftools/cmdutils.c:2046:32: error: implicit declaration of function 'GetModuleHandleA' [-Werror=implicit-function-declaration]
         if (GetModuleFileNameA(GetModuleHandleA(NULL), datadir, sizeof(datadir) - 1))
                                ^~~~~~~~~~~~~~~~
fftools/cmdutils.c:2043:14: warning: unused variable 'datadir' [-Wunused-variable]
         char datadir[MAX_PATH], *ls;
              ^~~~~~~
cc1: some warnings being treated as errors
----------------------------------

See the attached config.log for the options I used. I there something I've overlooked?

Cheers,
Jörg

-------------- next part --------------
A non-text attachment was scrubbed...
Name: config.log
Type: application/octet-stream
Size: 722089 bytes
Desc: config.log
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200108/f3a930fc/attachment.obj>