[FFmpeg-devel] [PATCH] avcodec/h265_metadata_bsf: Add vps/sps/pps id offset

[Mark Thompson]

On 08/01/2020 16:47, Eran Gonen wrote:
> ---
>  doc/bitstream_filters.texi     |   5 ++
>  libavcodec/h265_metadata_bsf.c | 106 +++++++++++++++++++++++++++++++--
>  2 files changed, 105 insertions(+), 6 deletions(-)

To repeat my previous comment, I don't think this belongs in h265_metadata since it's editing something which isn't really metadata.  A separate BSF for doing this sort of thing would make more sense (particularly if it then implemented some user-facing feature which you are using this transformation to enable).

Also note that you need to edit various SEI structures which refer to parameter set IDs as well (buffering_period most importantly, since that is very commonly used).

- Mark