[FFmpeg-devel] [PATCH V1 01/11] lavfi/spp: add "quality" option in runtime change path

mypopy at gmail.com mypopy at gmail.com
Mon Jan 13 03:32:25 EET 2020


On Mon, Jan 13, 2020 at 9:19 AM mypopy at gmail.com <mypopy at gmail.com> wrote:
>
> On Sun, Jan 12, 2020 at 2:50 AM Michael Niedermayer
> <michael at niedermayer.cc> wrote:
> >
> > On Sat, Jan 11, 2020 at 12:13:48PM +0800, Jun Zhao wrote:
> > > From: Jun Zhao <barryjzhao at tencent.com>
> > >
> > > it's stranage to use option "level" in runtime change path but used
> > > "quality" in option, add "quality" in runtime change path, it's more
> > > intuitive and keep the "level" for compatibility.
> > >
> > > Signed-off-by: Jun Zhao <barryjzhao at tencent.com>
> > > ---
> > >  doc/filters.texi     |    9 +++++++++
> > >  libavfilter/vf_spp.c |    2 +-
> > >  2 files changed, 10 insertions(+), 1 deletions(-)
> >
> > not sure both should be documented
> I can't find a special reason to document one argr, so will keep both.
> >
> > otherwise probably ok
patchset pushed, thanks


More information about the ffmpeg-devel mailing list