[FFmpeg-devel] [PATCH V1 01/11] lavfi/spp: add "quality" option in runtime change path

[mypopy at gmail.com]

On Tue, Jan 14, 2020 at 8:46 PM Moritz Barsnick <barsnick at gmx.net> wrote:
>
> On Tue, Jan 14, 2020 at 09:31:56 +0800, mypopy at gmail.com wrote:
> > > On Sat, Jan 11, 2020 at 12:13:48 +0800, Jun Zhao wrote:
> > > > +Same as quality option. And the command accepts the @code{max} same as the @code{6}.
>
> > > Are you trying to say that the allowed range for the command(s) is
> > > (are) the same as for the option?
>
> > No, from the code,
> >
> >     if (!strcmp(args, "max"))
> >              s->log2_count = MAX_LEVEL;
> >
> > this means, we can setting value "max" or "6" (MAX_LEVEL)
>
> Sorry, I didn't check the code, but was reading the docs from a user
> point of view.
>
> I suggest fixing this to:
>
> Same as quality option. The command accepts the value @code{max} with
> the same meaning as @code{6}.
>
Will update the doc part, thanks the suggestion.