[FFmpeg-devel] [PATCH v4 1/1] avdevice/gdigrab add use_captureblt option

[fgodt]

On 2020/1/14 上午7:24, Carl Eugen Hoyos wrote:
> Am Mo., 13. Jan. 2020 um 17:10 Uhr schrieb Derek Buitenhuis
> <derek.buitenhuis at gmail.com>:
>> On 11/01/2020 09:18, fgodtdev at hotmail.com wrote:
>>> From: FgoDt <fgodtdev at hotmail.com>
>>>
>>> Add use_captureblt option for disable or use CAPTUREBLT flag, when useing the bitblt function with CAPTUREBLT may caused the Windows mouse cursor flicker. most time we don't need this flag to capture window
>>> I tested on Windows 10 works fine
>>>
>>> Signed-off-by: fgodt <fgodtdev at hotmail.com>
>>> ---
>>>   doc/indevs.texi       |  7 +++++++
>>>   libavdevice/gdigrab.c | 10 +++++++++-
>>>   2 files changed, 16 insertions(+), 1 deletion(-)
>> Does it make sense to name this something like 'capature_layered_windows'?
>>
>> Using the name of the flag is a bit unintuitive from a user perspective.
> Not sure if "capture_layered_windows" is more intuitive than using the name
> of an os flag but ...
Agree with it
>> Same for the description.
> Shouldn't the description explain that this option helps against mouse
> cursor flicker?
I think explain is necessary, most people don't know this flag will make 
mouse flicker. If user find mouse cursor flicker they will find solution 
on doc

fgodt