[FFmpeg-devel] [PATCH] compat/w32pthreads: propagate the return value of SleepConditionVariableSRW()

[Hendrik Leppkes]

On Fri, Jan 17, 2020 at 2:41 AM James Almer <jamrial at gmail.com> wrote:
>
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>  compat/w32pthreads.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/compat/w32pthreads.h b/compat/w32pthreads.h
> index 21acfd2ba1..1ac4267c92 100644
> --- a/compat/w32pthreads.h
> +++ b/compat/w32pthreads.h
> @@ -152,8 +152,7 @@ static inline int pthread_cond_broadcast(pthread_cond_t *cond)
>
>  static inline int pthread_cond_wait(pthread_cond_t *cond, pthread_mutex_t *mutex)
>  {
> -    SleepConditionVariableSRW(cond, mutex, INFINITE, 0);
> -    return 0;
> +    return !SleepConditionVariableSRW(cond, mutex, INFINITE, 0);
>  }
>

The return of SleepConditionVariableSRW is not very meaningful, it
only returns success or failure, if we wanted to mimmick proper
pthread API, we could map a few common returns from GetLastError() to
their appropriate values.

- Hendrik