[FFmpeg-devel] [PATCH 5/5] avformat/mpeg: Don't use unintialized value
Michael Niedermayer
michael at niedermayer.cc
Sun Jan 19 13:56:58 EET 2020
On Tue, Oct 22, 2019 at 03:16:45PM +0200, Andreas Rheinhardt wrote:
> vobsub_read_packet() didn't check whether an index in array of AVPackets
> was valid and therefore used uninitialized values.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
> Actually I only wanted to use Valgrind to check for memleaks...
>
> libavformat/mpeg.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c
> index 73ade71d95..474afd06b9 100644
> --- a/libavformat/mpeg.c
> +++ b/libavformat/mpeg.c
> @@ -930,6 +930,10 @@ static int vobsub_read_packet(AVFormatContext *s, AVPacket *pkt)
> FFDemuxSubtitlesQueue *tmpq = &vobsub->q[i];
> int64_t ts;
> av_assert0(tmpq->nb_subs);
> +
> + if (tmpq->current_sub_idx >= tmpq->nb_subs)
> + continue;
How can this issue be reproduced ?
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200119/f84ff5d9/attachment.sig>
More information about the ffmpeg-devel
mailing list