[FFmpeg-devel] [PATCH] avformat/hlsenc: program_date_time and append_list flags conflict
Steven Liu
lq at chinaffmpeg.org
Mon Jan 20 08:43:39 EET 2020
> 在 2020年1月19日,17:20,Steven Liu <lq at chinaffmpeg.org> 写道:
>
>
>
>> 在 2020年1月19日,03:31,Bodecs Bela <bodecsb at vivanet.hu> 写道:
>>
>> sorry for missing patch file, here it is.
>>
>> Bela
>>
>>
>> 2020.01.18. 18:56 keltezéssel, Bodecs Bela írta:
>>> Dear All,
>>>
>>>
>>> When program_date_time flag is present, in m3u8 playlist file each
>>> segment has a corresponding EXT-X-PROGRAM-DATE-TIME value. The initial
>>> program-date-time value is the actual current time at init and
>>> each new segment increments this value by its duration. When append_list
>>> flags is also present, existing playlist parsing by hls_append_segment
>>> treats existing segments as new segments regarding the program-date-time
>>> calculation. But it should not do that, because this way all the real
>>> new segments' EXT-X-PROGRAM-DATE-TIME values will be shifted erroneously
>>> by the sum duration of existing segments. Instead it should have
>>> decremented the initial program-date-time value by its duration. This
>>> would ensure that the first new segment's program-date-time value had
>>> the current time as it is expected.
>>> This patch corrects this behaviour and prevent existing segments to
>>> increment the value of initial_prog_date_time variable but decrements
>>> it.
>>>
>>>
>>> please review this patch!
>>>
>>> thank you in advance,
> LGTM
Applied
>>>
>>> Bela
>>>
>>>
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel at ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>> <0001-avformat-hlsenc-program_date_time-and-append_list-fl.patch>_______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>
> Thanks
> Steven
>
>
>
>
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
Thanks
Steven
More information about the ffmpeg-devel
mailing list